feat: add toggleable labels for charts values by maximka76667 · Pull Request #551 · Hyperloop-UPV/software

maximka76667 · 2026-06-20T17:41:17Z

No description provided.

JavierRibaldelRio · 2026-06-20T19:23:28Z

@maximka76667
Event though the code looks great, I think is a little bit confusing. The idea of @jorgecanut was to add it next to the series name.

JavierRibaldelRio · 2026-06-20T19:27:12Z

And then this errors have appear:

error.txt

  VITE v7.3.1  ready in 1173 ms

  ➜  Local:   http://localhost:9000/
  ➜  Network: http://192.168.1.154:9000/
  ➜  Network: http://192.168.1.69:9000/
  ➜  press h + enter to show help

(!) Failed to run dependency scan. Skipping dependency pre-bundling. Error:   Failed to scan for dependencies from entries:
  /home/javierribaldelrio/HL/software/frontend/testing-view/index.html

  ✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/compo

nents/settings/SettingsDialog.tsx:4:47:
      4 │ ...ertTriangle, CheckCircle2, Loader2, X } from "@workspace/ui/icons";
        ╵                                        ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartLegend.tsx:1:22:
      1 │ import { Eye, EyeOff, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartSurface.tsx:3:36:
      3 │ import { ChevronLeft, ChevronRight, X } from "@workspace/ui/icons";
        ╵                                     ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/AddKeyBindingDialog.tsx:18:9:
      18 │ import { X } from "@workspace/ui/icons";
         ╵          ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/KeyBindingCard.tsx:2:22:
      2 │ import { ChevronDown, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/OrphanedKeyBindingCard.tsx:2:24:
      2 │ import { AlertTriangle, X } from "@workspace/ui/icons";
        ╵                         ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/RightSidebarHeader.tsx:8:2:
      8 │   X,
        ╵   ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/tabs/telemetry/TelemetryValue.tsx:2:16:
      2 │ import { Check, X } from "@workspace/ui/icons";
        ╵                 ^


    at failureErrorWithLog (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.j
s:1467:15)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:926:25
    at runOnEndCallbacks (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:
1307:45)
    at buildResponseToResult (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:924:7)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:936:9
    at new Promise (<anonymous>)
    at requestCallbacks.on-end (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/ma
in.js:935:54)
    at handleRequest (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:628:
17)
    at handleIncomingPacket (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.
js:653:7)
    at Socket.readFromStdout (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:581:7)
9:16:24 PM [vite] (client) ✨ new dependencies optimized: react, react-dom/client, react-router, @dnd-kit/core, zustand, zustand/
middleware, @base-ui/react, zustand/shallow, rxjs, rxjs/webSocket, lodash, @dnd-kit/sortable, lucide-react, @radix-ui/react-slot,
 class-variance-authority, radix-ui, @radix-ui/react-checkbox, @radix-ui/react-collapsible, @radix-ui/react-dialog, @radix-ui/rea
ct-dropdown-menu, @radix-ui/react-label, @radix-ui/react-popover, @radix-ui/react-separator, @radix-ui/react-select, react-resiza
ble-panels, @radix-ui/react-tabs, @radix-ui/react-tooltip, @dnd-kit/utilities, clsx, tailwind-merge, uplot, @tanstack/react-virtual

maximka76667 · 2026-06-20T19:38:51Z

@maximka76667
Event though the code looks great, I think is a little bit confusing. The idea of @jorgecanut was to add it next to the series name.

You mean put the value itself near the line name in the legend of a chart?

JavierRibaldelRio · 2026-06-20T19:43:40Z

Yes El sáb, 20 jun 2026 a las 21:39, Maxim ***@***.***>) escribió:

…

*maximka76667* left a comment (Hyperloop-UPV/software#551) <#551 (comment)> @maximka76667 <https://github.com/maximka76667> Event though the code looks great, I think is a little bit confusing. The idea of @jorgecanut <https://github.com/jorgecanut> was to add it next to the series name. image.png (view on web) <https://github.com/user-attachments/assets/2d925e8b-ec54-48bf-b9f0-a544d52e4876> You mean put the value itself near the line name in the legend of a chart? — Reply to this email directly, view it on GitHub <#551?email_source=notifications&email_token=AQYS5DL3TTBCWF52VM2AAXT5A3R6FA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVHE3TQNJSGE3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4759785216>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQYS5DLMQ7CC3S35Z7D2V4T5A3R6FAVCNFSNUABFKJSXA33TNF2G64TZHM3TCNBTGQ2TQNBSHNEXG43VMU5TINZQG43TOMBWGUZ2C5QC> . You are receiving this because your review was requested.Message ID: ***@***.***>

-- *Javier*

maximka76667 · 2026-06-20T19:47:50Z

Yes El sáb, 20 jun 2026 a las 21:39, Maxim @.>) escribió:
…
maximka76667 left a comment (Hyperloop-UPV/software#551) <#551 (comment)> @maximka76667 https://github.com/maximka76667 Event though the code looks great, I think is a little bit confusing. The idea of @jorgecanut https://github.com/jorgecanut was to add it next to the series name. image.png (view on web) https://github.com/user-attachments/assets/2d925e8b-ec54-48bf-b9f0-a544d52e4876 You mean put the value itself near the line name in the legend of a chart? — Reply to this email directly, view it on GitHub <#551?email_source=notifications&email_token=AQYS5DL3TTBCWF52VM2AAXT5A3R6FA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVHE3TQNJSGE3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4759785216>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQYS5DLMQ7CC3S35Z7D2V4T5A3R6FAVCNFSNUABFKJSXA33TNF2G64TZHM3TCNBTGQ2TQNBSHNEXG43VMU5TINZQG43TOMBWGUZ2C5QC . You are receiving this because your review was requested.Message ID: @.>
-- Javier

like this or without the option to hide it?

maximka76667 · 2026-06-20T19:52:11Z

And then this errors have appear:

error.txt

  VITE v7.3.1  ready in 1173 ms

  ➜  Local:   http://localhost:9000/
  ➜  Network: http://192.168.1.154:9000/
  ➜  Network: http://192.168.1.69:9000/
  ➜  press h + enter to show help

(!) Failed to run dependency scan. Skipping dependency pre-bundling. Error:   Failed to scan for dependencies from entries:
  /home/javierribaldelrio/HL/software/frontend/testing-view/index.html

  ✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/compo

nents/settings/SettingsDialog.tsx:4:47:
      4 │ ...ertTriangle, CheckCircle2, Loader2, X } from "@workspace/ui/icons";
        ╵                                        ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartLegend.tsx:1:22:
      1 │ import { Eye, EyeOff, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartSurface.tsx:3:36:
      3 │ import { ChevronLeft, ChevronRight, X } from "@workspace/ui/icons";
        ╵                                     ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/AddKeyBindingDialog.tsx:18:9:
      18 │ import { X } from "@workspace/ui/icons";
         ╵          ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/KeyBindingCard.tsx:2:22:
      2 │ import { ChevronDown, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/OrphanedKeyBindingCard.tsx:2:24:
      2 │ import { AlertTriangle, X } from "@workspace/ui/icons";
        ╵                         ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/RightSidebarHeader.tsx:8:2:
      8 │   X,
        ╵   ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/tabs/telemetry/TelemetryValue.tsx:2:16:
      2 │ import { Check, X } from "@workspace/ui/icons";
        ╵                 ^


    at failureErrorWithLog (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.j
s:1467:15)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:926:25
    at runOnEndCallbacks (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:
1307:45)
    at buildResponseToResult (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:924:7)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:936:9
    at new Promise (<anonymous>)
    at requestCallbacks.on-end (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/ma
in.js:935:54)
    at handleRequest (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:628:
17)
    at handleIncomingPacket (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.
js:653:7)
    at Socket.readFromStdout (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:581:7)
9:16:24 PM [vite] (client) ✨ new dependencies optimized: react, react-dom/client, react-router, @dnd-kit/core, zustand, zustand/
middleware, @base-ui/react, zustand/shallow, rxjs, rxjs/webSocket, lodash, @dnd-kit/sortable, lucide-react, @radix-ui/react-slot,
 class-variance-authority, radix-ui, @radix-ui/react-checkbox, @radix-ui/react-collapsible, @radix-ui/react-dialog, @radix-ui/rea
ct-dropdown-menu, @radix-ui/react-label, @radix-ui/react-popover, @radix-ui/react-separator, @radix-ui/react-select, react-resiza
ble-panels, @radix-ui/react-tabs, @radix-ui/react-tooltip, @dnd-kit/utilities, clsx, tailwind-merge, uplot, @tanstack/react-virtual

what did you run here?

JavierRibaldelRio · 2026-06-21T07:26:16Z

And then this errors have appear:
error.txt

  VITE v7.3.1  ready in 1173 ms

  ➜  Local:   http://localhost:9000/
  ➜  Network: http://192.168.1.154:9000/
  ➜  Network: http://192.168.1.69:9000/
  ➜  press h + enter to show help

(!) Failed to run dependency scan. Skipping dependency pre-bundling. Error:   Failed to scan for dependencies from entries:
  /home/javierribaldelrio/HL/software/frontend/testing-view/index.html

  ✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/compo

nents/settings/SettingsDialog.tsx:4:47:
      4 │ ...ertTriangle, CheckCircle2, Loader2, X } from "@workspace/ui/icons";
        ╵                                        ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartLegend.tsx:1:22:
      1 │ import { Eye, EyeOff, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/charts/components/ChartSurface.tsx:3:36:
      3 │ import { ChevronLeft, ChevronRight, X } from "@workspace/ui/icons";
        ╵                                     ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/AddKeyBindingDialog.tsx:18:9:
      18 │ import { X } from "@workspace/ui/icons";
         ╵          ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/KeyBindingCard.tsx:2:22:
      2 │ import { ChevronDown, X } from "@workspace/ui/icons";
        ╵                       ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/keyBindings/components/OrphanedKeyBindingCard.tsx:2:24:
      2 │ import { AlertTriangle, X } from "@workspace/ui/icons";
        ╵                         ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/RightSidebarHeader.tsx:8:2:
      8 │   X,
        ╵   ^


✘ [ERROR] Ambiguous import "X" has multiple matching exports

    src/features/workspace/components/rightSidebar/tabs/telemetry/TelemetryValue.tsx:2:16:
      2 │ import { Check, X } from "@workspace/ui/icons";
        ╵                 ^


    at failureErrorWithLog (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.j
s:1467:15)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:926:25
    at runOnEndCallbacks (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:
1307:45)
    at buildResponseToResult (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:924:7)
    at /home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:936:9
    at new Promise (<anonymous>)
    at requestCallbacks.on-end (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/ma
in.js:935:54)
    at handleRequest (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.js:628:
17)
    at handleIncomingPacket (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main.
js:653:7)
    at Socket.readFromStdout (/home/javierribaldelrio/HL/software/node_modules/.pnpm/esbuild@0.27.2/node_modules/esbuild/lib/main
.js:581:7)
9:16:24 PM [vite] (client) ✨ new dependencies optimized: react, react-dom/client, react-router, @dnd-kit/core, zustand, zustand/
middleware, @base-ui/react, zustand/shallow, rxjs, rxjs/webSocket, lodash, @dnd-kit/sortable, lucide-react, @radix-ui/react-slot,
 class-variance-authority, radix-ui, @radix-ui/react-checkbox, @radix-ui/react-collapsible, @radix-ui/react-dialog, @radix-ui/rea
ct-dropdown-menu, @radix-ui/react-label, @radix-ui/react-popover, @radix-ui/react-separator, @radix-ui/react-select, react-resiza
ble-panels, @radix-ui/react-tabs, @radix-ui/react-tooltip, @dnd-kit/utilities, clsx, tailwind-merge, uplot, @tanstack/react-virtual

what did you run here?

pnpm run dev --filter="testing-view, but now after your last commit does not happen. So it's great. ;-)

JavierRibaldelRio · 2026-06-21T07:29:38Z

Yes El sáb, 20 jun 2026 a las 21:39, Maxim @.>) escribió:
…
maximka76667 left a comment (Hyperloop-UPV/software#551) <#551 (comment)> @maximka76667 https://github.com/maximka76667 Event though the code looks great, I think is a little bit confusing. The idea of @jorgecanut https://github.com/jorgecanut was to add it next to the series name. image.png (view on web) https://github.com/user-attachments/assets/2d925e8b-ec54-48bf-b9f0-a544d52e4876 You mean put the value itself near the line name in the legend of a chart? — Reply to this email directly, view it on GitHub <#551?email_source=notifications&email_token=AQYS5DL3TTBCWF52VM2AAXT5A3R6FA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZVHE3TQNJSGE3KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4759785216>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQYS5DLMQ7CC3S35Z7D2V4T5A3R6FAVCNFSNUABFKJSXA33TNF2G64TZHM3TCNBTGQ2TQNBSHNEXG43VMU5TINZQG43TOMBWGUZ2C5QC . You are receiving this because your review was requested.Message ID: _@**.**_>
-- Javier

like this or without the option to hide it?

For me like this is fine, you can keep the option to hide it. In case where you have multiple series you might find interesting to reduce the size of each at the legent.

Have you considered adding the unit, for example, instead of just 7 152.83 add 152.83 mm? in the same way it is done on packages

JavierRibaldelRio

LGTM.

feat: add toggleable labeles for charts values

8e4a890

maximka76667 requested review from a team, Humanoidear, JavierRibaldelRio, l-castel and vasyl-ks and removed request for Humanoidear, JavierRibaldelRio, l-castel and vasyl-ks June 20, 2026 17:41

maximka76667 changed the title ~~feat: add toggleable labeles for charts values~~ feat: add toggleable labels for charts values Jun 20, 2026

maximka76667 added 2 commits June 20, 2026 21:55

feat: remove labeled values and add them in the legend

ce025e0

fix: duplicate export of X lucid icon

3beddeb

JavierRibaldelRio approved these changes Jun 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add toggleable labels for charts values#551

feat: add toggleable labels for charts values#551
maximka76667 wants to merge 3 commits into
developfrom
testing-view/labeled-charts-values

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 20, 2026 •

edited

Loading

Uh oh!

JavierRibaldelRio commented Jun 20, 2026

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 20, 2026 via email

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 21, 2026 •

edited

Loading

Uh oh!

JavierRibaldelRio commented Jun 21, 2026

Uh oh!

JavierRibaldelRio left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JavierRibaldelRio commented Jun 20, 2026

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 20, 2026 via email

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

maximka76667 commented Jun 20, 2026

Uh oh!

JavierRibaldelRio commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JavierRibaldelRio commented Jun 21, 2026

Uh oh!

JavierRibaldelRio left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JavierRibaldelRio commented Jun 20, 2026 •

edited

Loading

JavierRibaldelRio commented Jun 21, 2026 •

edited

Loading